Build: Fix slow tests #773
Conversation
JAVA-4145
| } | ||
| } | ||
|
|
||
| task testSlowGroovy(type: Test) { |
There was a problem hiding this comment.
Had to create a custom task just for the groovy tests and that fixes the issue ?!
There was a problem hiding this comment.
Yes, thats's what seem to be suggested as the solution, which is unfortunate: spockframework/spock#1288 (comment).
| } | ||
|
|
||
| task testSlowOnly(type: Test) { | ||
| dependsOn('testSlowGroovy') |
There was a problem hiding this comment.
Add the spock test dependency
| import static com.mongodb.ClusterFixture.getSslSettings | ||
| import static com.mongodb.internal.connection.CommandHelper.executeCommand | ||
|
|
||
| @IgnoreIf({ System.getProperty('ignoreSlowUnitTests') == 'true' }) |
There was a problem hiding this comment.
This seems to be a legacy system property
| def 'should throw a MongoSocketOpenException when the AsynchronousSocket Stream fails to open'() { | ||
| given: | ||
| def connection = new InternalStreamConnectionFactory( | ||
| def connection = new InternalStreamConnectionFactory(ClusterConnectionMode.SINGLE, |
There was a problem hiding this comment.
These changes are just to bring the code up to date.
|
|
||
| then: 'it prunes the existing connections and again ensures the minimum size of the pool' | ||
| connectionFactory.createdConnections.size() == 10 | ||
| connectionFactory.createdConnections.size() == 5 |
| class ClientSideEncryptionBsonSizeLimitsSpecification extends FunctionalSpecification { | ||
|
|
||
| private final String collectionName = 'ClientSideEncryptionBsonSizeLimitsSpecification' | ||
| private final String collName = 'ClientSideEncryptionBsonSizeLimitsSpecification' |
There was a problem hiding this comment.
Side effect of Spock dependency update? Theres a getCollectionName method in the FunctionalSpecification and spock complained they clashed.
| } | ||
| } | ||
|
|
||
| task testSlowGroovy(type: Test) { |
There was a problem hiding this comment.
Yes, thats's what seem to be suggested as the solution, which is unfortunate: spockframework/spock#1288 (comment).
3 participants
JAVA-4145
https://spruce.mongodb.com/version/610bebf90ae606191fe957b7 - for the slow tests